Autocomplete: Fix closing slash inserter with ESC #23859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the slash inserter closes when the user presses ESC by properly resetting both `autocompleter` and `AutocompleterUI` (added in 3156d0b) from component state. Also prevent the block editor from going into Select mode by stopping event propagation when the Autocomplete component handles a key press.
noisysocks
added
[Type] Bug
|
Size Change: +13 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jul 13, 2020
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2020
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23821.
Ensure that the slash inserter closes when the user presses ESC by properly resetting both
autocompleterandAutocompleterUI(added in #22853) from component state.Also prevent the block editor from going into Select mode by stopping event propagation when the Autocomplete component handles a key press.
To test:
/in the paragraph.esc.